Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

[Kees Cook]

On Sun, Sep 4, 2016 at 7:38 AM, Namhyung Kim <address@hidden> wrote:
> The virtio pstore driver provides interface to the pstore subsystem so
> that the guest kernel's log/dump message can be saved on the host
> machine.  Users can access the log file directly on the host, or on the
> guest at the next boot using pstore filesystem.  It currently deals with
> kernel log (printk) buffer only, but we can extend it to have other
> information (like ftrace dump) later.
>
> It supports legacy PCI device using a 16K buffer by default and it's
> configurable.  It uses two virtqueues - one for (sync) read and another
> for (async) write.  Since it cannot wait for write finished, it supports
> up to 128 concurrent IO.
>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Radim Krčmář <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Anthony Liguori <address@hidden>
> Cc: Anton Vorontsov <address@hidden>
> Cc: Colin Cross <address@hidden>
> Cc: Kees Cook <address@hidden>
> Cc: Tony Luck <address@hidden>
> Cc: Steven Rostedt <address@hidden>
> Cc: Ingo Molnar <address@hidden>
> Cc: Minchan Kim <address@hidden>
> Cc: Will Deacon <address@hidden>
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
> Signed-off-by: Namhyung Kim <address@hidden>

While I can't speak to the virtio parts, the interface into pstore
looks fine to me. :)

Reviewed-by: Kees Cook <address@hidden>

-Kees

-- 
Kees Cook
Nexus Security