qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 09/27] tcg: Add atomic helpers


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 09/27] tcg: Add atomic helpers
Date: Thu, 8 Sep 2016 09:08:48 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 09/08/2016 06:43 AM, Alex Bennée wrote:
>>  DATA_TYPE
>> > +#undef DATAX_TYPE
> Accidental typo?

It wasn't, actually, but...

>> >  #undef SUFFIX
>> >  #undef LSUFFIX
>> >  #undef DATA_SIZE
>> > @@ -524,8 +696,6 @@ void probe_write(CPUArchState *env, target_ulong addr, 
>> > int mmu_idx,
>> >  #undef BSWAP
>> >  #undef TGT_BE
>> >  #undef TGT_LE
>> > -#undef CPU_BE
>> > -#undef CPU_LE
> I suspect these belong in a separate clean-up patch?
> 

Please look at the v3 patch set instead.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]