[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v16 11/16] hw/ptimer: Add "no immediate reload" poli
From: |
Dmitry Osipenko |
Subject: |
[Qemu-devel] [PATCH v16 11/16] hw/ptimer: Add "no immediate reload" policy |
Date: |
Wed, 7 Sep 2016 16:22:22 +0300 |
Immediate counter re-load on setting (or on starting to run with)
counter = 0 is a wrong behaviour for some of the timers. Add "no
immediate reload" policy that provides correct behaviour for such timers.
Signed-off-by: Dmitry Osipenko <address@hidden>
---
hw/core/ptimer.c | 8 +++++---
include/hw/ptimer.h | 3 +++
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/core/ptimer.c b/hw/core/ptimer.c
index 018589d..f7f5538 100644
--- a/hw/core/ptimer.c
+++ b/hw/core/ptimer.c
@@ -45,7 +45,7 @@ static void ptimer_reload(ptimer_state *s, int delta_adjust)
ptimer_trigger(s);
}
- if (delta == 0) {
+ if (delta == 0 && !(s->policy_mask & PTIMER_POLICY_NO_IMMEDIATE_RELOAD)) {
delta = s->delta = s->limit;
}
@@ -107,11 +107,13 @@ static void ptimer_tick(void *opaque)
{
ptimer_state *s = (ptimer_state *)opaque;
ptimer_trigger(s);
- s->delta = 0;
if (s->enabled == 2) {
+ s->delta = 0;
s->enabled = 0;
} else {
- ptimer_reload(s, 1);
+ int delta_adjust = (s->delta != 0 && s->limit != 0) ? 1 : 0;
+ s->delta = s->limit;
+ ptimer_reload(s, delta_adjust);
}
}
diff --git a/include/hw/ptimer.h b/include/hw/ptimer.h
index 4b7c53c..131fed1 100644
--- a/include/hw/ptimer.h
+++ b/include/hw/ptimer.h
@@ -46,6 +46,9 @@
* trigger. */
#define PTIMER_POLICY_NO_IMMEDIATE_TRIGGER (1 << 2)
+/* Starting to run with/setting counter = 0 won't re-load counter. */
+#define PTIMER_POLICY_NO_IMMEDIATE_RELOAD (1 << 3)
+
/* ptimer.c */
typedef struct ptimer_state ptimer_state;
typedef void (*ptimer_cb)(void *opaque);
--
2.9.3
- [Qemu-devel] [PATCH v16 05/16] hw/ptimer: Add "wraparound after one period" policy, (continued)
- [Qemu-devel] [PATCH v16 05/16] hw/ptimer: Add "wraparound after one period" policy, Dmitry Osipenko, 2016/09/07
- [Qemu-devel] [PATCH v16 10/16] tests: ptimer: Add tests for "no immediate trigger" policy, Dmitry Osipenko, 2016/09/07
- [Qemu-devel] [PATCH v16 02/16] hw/ptimer: Introduce timer policy feature, Dmitry Osipenko, 2016/09/07
- [Qemu-devel] [PATCH v16 08/16] tests: ptimer: Add tests for "continuous trigger" policy, Dmitry Osipenko, 2016/09/07
- [Qemu-devel] [PATCH v16 07/16] hw/ptimer: Add "continuous trigger" policy, Dmitry Osipenko, 2016/09/07
- [Qemu-devel] [PATCH v16 06/16] tests: ptimer: Add tests for "wraparound after one period" policy, Dmitry Osipenko, 2016/09/07
- [Qemu-devel] [PATCH v16 09/16] hw/ptimer: Add "no immediate trigger" policy, Dmitry Osipenko, 2016/09/07
- [Qemu-devel] [PATCH v16 12/16] tests: ptimer: Add tests for "no immediate reload" policy, Dmitry Osipenko, 2016/09/07
- [Qemu-devel] [PATCH v16 11/16] hw/ptimer: Add "no immediate reload" policy,
Dmitry Osipenko <=
- [Qemu-devel] [PATCH v16 15/16] arm_mptimer: Convert to use ptimer, Dmitry Osipenko, 2016/09/07
- [Qemu-devel] [PATCH v16 14/16] tests: ptimer: Add tests for "no counter round down" policy, Dmitry Osipenko, 2016/09/07
- [Qemu-devel] [PATCH v16 13/16] hw/ptimer: Add "no counter round down" policy, Dmitry Osipenko, 2016/09/07
- [Qemu-devel] [PATCH v16 16/16] tests: Add tests for the ARM MPTimer, Dmitry Osipenko, 2016/09/07
- Re: [Qemu-devel] [PATCH v16 00/16] PTimer fixes/features and ARM MPTimer conversion, Peter Maydell, 2016/09/20