|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [RFC v4 16/28] tcg: drop global lock during TCG code execution |
Date: | Tue, 6 Sep 2016 23:43:24 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 09/06/2016 10:43 PM, Paolo Bonzini wrote:
On 07/09/2016 06:03, Richard Henderson wrote:+ if (mr->global_locking) { + qemu_mutex_lock_iothread(); + locked = true; + } memory_region_dispatch_read(mr, physaddr, &val, 1 << SHIFT, iotlbentry->attrs); + if (locked) { + qemu_mutex_unlock_iothread(); + }I'm not keen on this pattern. (1) Why not use recursive locks?Probably I'm biased by looking at this code too long, but... how would they help?
You wouldn't check to see if the lock is already taken. r~
[Prev in Thread] | Current Thread | [Next in Thread] |