[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [Patch v4 22/30] s390x/kvm: disable host model for problema
From: |
David Hildenbrand |
Subject: |
[Qemu-devel] [Patch v4 22/30] s390x/kvm: disable host model for problematic compat machines |
Date: |
Mon, 5 Sep 2016 10:52:36 +0200 |
Compatibility machines that touch runtime-instrumentation should not
be used with the CPU model. Otherwise the host model will look different,
depending on the QEMU machine QEMU has been started with.
So let's simply disable the host model for existing compatibility machines
that all disable ri. This, in return, disables the CPU model for these
compat machines completely.
Acked-by: Cornelia Huck <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target-s390x/kvm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index 2cc0357..3c0929b 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -2451,6 +2451,10 @@ static int configure_cpu_feat(const S390FeatBitmap
features)
bool kvm_s390_cpu_models_supported(void)
{
+ if (!ri_allowed()) {
+ /* compatibility machines interfere with the cpu model */
+ return false;
+ }
return kvm_vm_check_attr(kvm_state, KVM_S390_VM_CPU_MODEL,
KVM_S390_VM_CPU_MACHINE) &&
kvm_vm_check_attr(kvm_state, KVM_S390_VM_CPU_MODEL,
--
2.8.4
- [Qemu-devel] [Patch v4 29/30] s390x/cpumodel: implement QMP interface "query-cpu-model-comparison", (continued)
- [Qemu-devel] [Patch v4 29/30] s390x/cpumodel: implement QMP interface "query-cpu-model-comparison", David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 14/30] s390x/sclp: introduce sclp feature blocks, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 06/30] s390x/cpumodel: generate CPU feature group lists, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 13/30] s390x/sclp: factor out preparation of cpu entries, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 15/30] s390x/sclp: indicate sclp features, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 03/30] s390x/cpumodel: expose CPU class properties, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 10/30] s390x/cpumodel: expose features and feature groups as properties, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 30/30] s390x/cpumodel: implement QMP interface "query-cpu-model-baseline", David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 12/30] s390x/cpumodel: check and apply the CPU model, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 23/30] s390x/kvm: let the CPU model control CMM(A), David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 22/30] s390x/kvm: disable host model for problematic compat machines,
David Hildenbrand <=
- [Qemu-devel] [Patch v4 02/30] s390x/cpumodel: "host" and "qemu" as CPU subclasses, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 11/30] s390x/cpumodel: let the CPU model handle feature checks, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 17/30] s390x/sclp: propagate the mha via sclp, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 24/30] s390x/kvm: don't enable key wrapping if msa3 is disabled, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 08/30] s390x/cpumodel: register defined CPU models as subclasses, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 18/30] s390x/sclp: propagate hmfai, David Hildenbrand, 2016/09/05
- [Qemu-devel] [Patch v4 26/30] qmp: add QMP interface "query-cpu-model-comparison", David Hildenbrand, 2016/09/05
- Re: [Qemu-devel] [Patch v4 00/30] s390x CPU models: exposing features, Cornelia Huck, 2016/09/05
- Re: [Qemu-devel] [Patch v4 00/30] s390x CPU models: exposing features, no-reply, 2016/09/05
- Re: [Qemu-devel] [Patch v4 00/30] s390x CPU models: exposing features, Cornelia Huck, 2016/09/05