Re: [Qemu-devel] [PATCH 00/18] virgl: use a seperate rendering thread

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 00/18] virgl: use a seperate rendering thread
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
8abc39d virtio-gpu: start/stop the data-plane
f75ff94 virtio-gpu: schedule a bh to unblock the data-plane
43e0ecf virtio-gpu: use virgl thread sync with the data-plane
e3a2562 virtio-gpu: dispatch to main thread for scanout & flush
2549b27 virtio-gpu: batch virtio_notify when using a data-plane
e9855b7 virtio-gpu: add a virgl data-plane
7bd9911 virtio-gpu: save a pointer from virtio_gpu_ctrl_command
fd2ff41 virtio-gpu: use a bh for cursor modifications
a24e803 virtio-blk: use bitmap_foreach
d0f8002 bitmap: add a simple foreach util
944536e gl: bind GL api before context creation
1f37504 gl: allow to keep current context in ctx-create
a2b4c5f virtio-gpu: create a thread context
2823f8f virtio-gpu: start introducing a lock around the display info
8874c04 virtio-gpu: start splitting scanout/resource flushing
f86af9a virtio-gpu: add "iothread" property
5cf1883 console: add dpy_gl_ctx_is_mt_safe
9bc3d8c console: skip same-size resize

=== OUTPUT BEGIN ===
Checking PATCH 1/18: console: skip same-size resize...
Checking PATCH 2/18: console: add dpy_gl_ctx_is_mt_safe...
Checking PATCH 3/18: virtio-gpu: add "iothread" property...
Checking PATCH 4/18: virtio-gpu: start splitting scanout/resource flushing...
ERROR: braces {} are necessary for all arms of this statement
#70: FILE: hw/display/virtio-gpu-3d.c:168:
+        if (info->idx != 0)
[...]

total: 1 errors, 0 warnings, 136 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/18: virtio-gpu: start introducing a lock around the display 
info...
Checking PATCH 6/18: virtio-gpu: create a thread context...
Checking PATCH 7/18: gl: allow to keep current context in ctx-create...
Checking PATCH 8/18: gl: bind GL api before context creation...
Checking PATCH 9/18: bitmap: add a simple foreach util...
Checking PATCH 10/18: virtio-blk: use bitmap_foreach...
Checking PATCH 11/18: virtio-gpu: use a bh for cursor modifications...
Checking PATCH 12/18: virtio-gpu: save a pointer from virtio_gpu_ctrl_command...
Checking PATCH 13/18: virtio-gpu: add a virgl data-plane...
Checking PATCH 14/18: virtio-gpu: batch virtio_notify when using a data-plane...
Checking PATCH 15/18: virtio-gpu: dispatch to main thread for scanout & flush...
Checking PATCH 16/18: virtio-gpu: use virgl thread sync with the data-plane...
Checking PATCH 17/18: virtio-gpu: schedule a bh to unblock the data-plane...
Checking PATCH 18/18: virtio-gpu: start/stop the data-plane...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden