Re: [Qemu-devel] [PATCH RFC v2 01/22] block/pcache: empty pcache driver filter

[Kevin Wolf]

Am 29.08.2016 um 19:10 hat Pavel Butsykin geschrieben:
> The basic version of pcache driver for easy preparation of a patch set.
> 
> Signed-off-by: Pavel Butsykin <address@hidden>

> +    .bdrv_aio_readv                     = pcache_aio_readv,
> +    .bdrv_aio_writev                    = pcache_aio_writev,

Can you please use .bdrv_co_preadv/pwritev instead and make everything
based on bytes rather than sectors?

Internally you can still spawn AIO requests to achieve the same
parallelism as you have now (we'll just need new byte-based
bdrv_co_aio_prw_vector() wrappers, but the functionality is there) and I
don't think making the outer layer coroutine based would be too hard. In
fact it might even simplify some code.

Kevin