[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] virtio-pci: error out when both legacy and m
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH v5] virtio-pci: error out when both legacy and modern modes are disabled |
Date: |
Wed, 31 Aug 2016 15:41:32 +0200 |
Michael,
I realize this patch fell through the cracks while I was away... the various
reviews seemed to indicate there was a consensus to have this in 2.7 though.
Do you have an opinion whether QEMU needs this or not ?
Cc'ing Peter in case it is acceptable to apply the patch this late.
Cheers.
--
Greg
On Fri, 22 Jul 2016 16:05:29 +0200
Greg Kurz <address@hidden> wrote:
> From: Greg Kurz <address@hidden>
>
> Without presuming if we got there because of a user mistake or some
> more subtle bug in the tooling, it really does not make sense to
> implement a non-functional device.
>
> Signed-off-by: Greg Kurz <address@hidden>
> Reviewed-by: Marcel Apfelbaum <address@hidden>
> Reviewed-by: Cornelia Huck <address@hidden>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> v5: - changed wording as suggested by Connie
> - added Connies R-b tag
> ---
> hw/virtio/virtio-pci.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index 755f9218b77d..8714123d61fd 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -1842,6 +1842,14 @@ static void virtio_pci_dc_realize(DeviceState *qdev,
> Error **errp)
> VirtIOPCIProxy *proxy = VIRTIO_PCI(qdev);
> PCIDevice *pci_dev = &proxy->pci_dev;
>
> + if (!(virtio_pci_modern(proxy) || virtio_pci_legacy(proxy))) {
> + error_setg(errp, "device cannot work as neither modern nor legacy
> mode"
> + " is enabled");
> + error_append_hint(errp, "Set either disable-modern or disable-legacy"
> + " to off\n");
> + return;
> + }
> +
> if (!(proxy->flags & VIRTIO_PCI_FLAG_DISABLE_PCIE) &&
> virtio_pci_modern(proxy)) {
> pci_dev->cap_present |= QEMU_PCI_CAP_EXPRESS;
>
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v5] virtio-pci: error out when both legacy and modern modes are disabled,
Greg Kurz <=