Re: [Qemu-devel] [PATCH for-2.8 v3 1/3] scripts: Allow block module to not define BlockDriver

[Max Reitz]

On 17.08.2016 09:20, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  scripts/modules/module_block.py | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/scripts/modules/module_block.py b/scripts/modules/module_block.py
> index db4fb54..7efec00 100644
> --- a/scripts/modules/module_block.py
> +++ b/scripts/modules/module_block.py
> @@ -56,11 +56,6 @@ def process_file(fheader, filename):
>                  format_name = ""
>                  protocol_name = ""
>  
> -        if not found_something:
> -            print("No BlockDriver struct found in " + filename + ". \
> -                    Is this really a module?", file=sys.stderr)
> -            sys.exit(1)

found_something is now unused. Do you want to remove it?

Max

> -
>  def print_top(fheader):
>      fheader.write('''/* AUTOMATICALLY GENERATED, DO NOT MODIFY */
>  /*
>

signature.asc
Description: OpenPGP digital signature