Re: [Qemu-devel] [PATCH for-2.8 2/2] vhost-vsock: add virtio sockets device

[Cornelia Huck]

On Tue, 23 Aug 2016 19:45:15 +0200
Claudio Imbrenda <address@hidden> wrote:

> Hi Stefan!
> 
> I tried it on s390x and... it doesn't compile :(
> Something has been changed somewhere behind our backs, and you need to 
> change this line to get it to compile again:
> 
> --- virtio-ccw.c~       2016-08-23 16:37:14.000000000 +0200
> +++ virtio-ccw.c        2016-08-23 16:41:10.587853314 +0200
> @@ -1661,7 +1661,7 @@
>   #ifdef CONFIG_VHOST_VSOCK
> 
>   static Property vhost_vsock_ccw_properties[] = {
> -    DEFINE_PROP_STRING("devno", VirtioCcwDevice, bus_id),
> +    DEFINE_PROP_CSS_DEV_ID("devno", VirtioCcwDevice, parent_obj.bus_id),
>       DEFINE_PROP_UINT32("max_revision", VirtioCcwDevice, max_rev,
>                          VIRTIO_CCW_MAX_REV),
>       DEFINE_PROP_END_OF_LIST(),

This was changed completely in the open ;)

Your change looks correct to me.