Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
12a04a4 cutils: Rewrite ppc buffer zero checking
2841895 cutils: Rewrite aarch64 buffer zero checking
00cb541 cutils: Rewrite x86 buffer zero checking
457e08e cutils: Add generic prefetch
4063093 cutils: Rearrange buffer_is_zero acceleration
514f601 cutils: Export only buffer_is_zero
aabd7b2 cutils: Remove SPLAT macro

=== OUTPUT BEGIN ===
Checking PATCH 1/7: cutils: Remove SPLAT macro...
Checking PATCH 2/7: cutils: Export only buffer_is_zero...
Checking PATCH 3/7: cutils: Rearrange buffer_is_zero acceleration...
ERROR: externs should be avoided in .c files
#124: FILE: util/cutils.c:166:
+extern void link_error(void);

ERROR: spaces required around that '*' (ctx:VxV)
#218: FILE: util/cutils.c:229:
+ACCEL_BUFFER_ZERO(buffer_zero_int, 4*sizeof(long), long, IDENT_ZERO)
                                     ^

ERROR: architecture specific defines should be avoided
#238: FILE: util/cutils.c:243:
+#ifdef __ALTIVEC__

ERROR: space required before the open brace '{'
#250: FILE: util/cutils.c:255:
+#define DO_ZERO(X)  vec_all_eq(X, (__vector unsigned char){ 0 })

total: 4 errors, 0 warnings, 446 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/7: cutils: Add generic prefetch...
Checking PATCH 5/7: cutils: Rewrite x86 buffer zero checking...
ERROR: Use of volatile is usually wrong: see 
Documentation/volatile-considered-harmful.txt
#44: FILE: util/cutils.c:289:
+        __asm volatile("vmovdqu -0x80(%1),%0\n\t"

ERROR: externs should be avoided in .c files
#44: FILE: util/cutils.c:289:
+        __asm volatile("vmovdqu -0x80(%1),%0\n\t"

ERROR: Use of volatile is usually wrong: see 
Documentation/volatile-considered-harmful.txt
#72: FILE: util/cutils.c:317:
+        __asm volatile("vmovdqu -0x40(%1),%0\n\t"

ERROR: externs should be avoided in .c files
#72: FILE: util/cutils.c:317:
+        __asm volatile("vmovdqu -0x40(%1),%0\n\t"

ERROR: Use of volatile is usually wrong: see 
Documentation/volatile-considered-harmful.txt
#98: FILE: util/cutils.c:343:
+        __asm volatile("movdqu -0x40(%4),%0\n\t"

ERROR: externs should be avoided in .c files
#98: FILE: util/cutils.c:343:
+        __asm volatile("movdqu -0x40(%4),%0\n\t"

ERROR: Use of volatile is usually wrong: see 
Documentation/volatile-considered-harmful.txt
#132: FILE: util/cutils.c:374:
+        __asm volatile("movdqu -0x40(%4),%0\n\t"

ERROR: externs should be avoided in .c files
#132: FILE: util/cutils.c:374:
+        __asm volatile("movdqu -0x40(%4),%0\n\t"

ERROR: architecture specific defines should be avoided
#166: FILE: util/cutils.c:439:
+#ifdef __AVX2__

ERROR: architecture specific defines should be avoided
#169: FILE: util/cutils.c:442:
+#ifdef __AVX__

ERROR: architecture specific defines should be avoided
#172: FILE: util/cutils.c:445:
+#ifdef __SSE4_1__

ERROR: architecture specific defines should be avoided
#175: FILE: util/cutils.c:448:
+#ifdef __SSE2__

total: 12 errors, 0 warnings, 198 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/7: cutils: Rewrite aarch64 buffer zero checking...
Checking PATCH 7/7: cutils: Rewrite ppc buffer zero checking...
ERROR: Use of volatile is usually wrong: see 
Documentation/volatile-considered-harmful.txt
#37: FILE: util/cutils.c:270:
+        __asm volatile("lvebx %0,%4,%5\n\t"

ERROR: externs should be avoided in .c files
#37: FILE: util/cutils.c:270:
+        __asm volatile("lvebx %0,%4,%5\n\t"

total: 2 errors, 0 warnings, 47 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden