qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] virtio: fix VirtQueue->inuse field


From: Denis V. Lunev
Subject: Re: [Qemu-devel] [PATCH 0/2] virtio: fix VirtQueue->inuse field
Date: Mon, 22 Aug 2016 14:23:07 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 08/22/2016 10:00 AM, Denis V. Lunev wrote:
On 08/15/2016 08:54 AM, Stefan Hajnoczi wrote:
The VirtQueue->inuse field is not always updated correctly. These patches fix
it.

Originally this series was called "virtio-balloon: fix stats vq migration" but Ladi Prosek posted a nicer fix called "balloon: Fix failure of updating guest
memory status".  I dropped the virtio-balloon patches.

Changes from previous series:
  * Missing comma in error formatting [Fam]
  * virtio_descard() -> virtio_discard() [Michael]
  * Multi-line comment style [Cornelia]

Stefan Hajnoczi (2):
   virtio: recalculate vq->inuse after migration
   virtio: decrement vq->inuse in virtqueue_discard()

  hw/virtio/virtio.c | 16 ++++++++++++++++
  1 file changed, 16 insertions(+)

these patches break 'make check' with the following:

GTESTER check-qtest-x86_64
Warning: path not on HugeTLBFS: /tmp/vhost-test-hRYeTb
Warning: path not on HugeTLBFS: /tmp/vhost-test-hRYeTb
Warning: path not on HugeTLBFS: /tmp/vhost-test-hRYeTb
qemu-system-x86_64: VQ 1 size 0x100 < last_avail_idx 0x0 - used_idx 0x1
qemu-system-x86_64: error while loading state for instance 0x0 of device '0000:00:03.0/virtio-net'
qemu-system-x86_64: load of migration failed: Operation not permitted
Broken pipe
qemu-system-x86_64: Failed to read msg header. Read 0 instead of 12. Original request 11.
GTester: last random seed: R02S122f07a3fc35cfd5b0204e3eb45c61e6
qemu-system-x86_64: Failed to read msg header. Read 0 instead of 12. Original request 11.
Warning: path not on HugeTLBFS: /tmp/vhost-test-60WtDz
blkdebug: Suspended request 'A'
blkdebug: Resuming request 'A'
main-loop: WARNING: I/O thread spun for 1000 iterations
main-loop: WARNING: I/O thread spun for 1000 iterations
/home/den/src/git/qemu/tests/Makefile:400: recipe for target 'check-qtest-x86_64' failed
make: *** [check-qtest-x86_64] Error 1
iris ~/src/git/qemu $

Sorry, if I have missed the fix in the list.

Den

VERY sorry, pls disregard. This is my mistake :(

Den



reply via email to

[Prev in Thread] Current Thread [Next in Thread]