Re: [Qemu-devel] [PATCH v17 6/9] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions

[Peter Maydell]

On 18 August 2016 at 13:07, Michael Rolnik <address@hidden> wrote:
> Signed-off-by: Michael Rolnik <address@hidden>

> @@ -79,11 +80,11 @@ void avr_cpu_do_interrupt(CPUState *cs)
>
>      if (avr_feature(env, AVR_FEATURE_3_BYTE_PC)) {
>          cpu_stb_data(env, env->sp--, (ret & 0x0000ff));
> -        cpu_stb_data(env, env->sp--, (ret & 0x00ff00) >>  8);
> +        cpu_stb_data(env, env->sp--, (ret & 0x00ff00) >> 8);
>          cpu_stb_data(env, env->sp--, (ret & 0xff0000) >> 16);
>      } else if (avr_feature(env, AVR_FEATURE_2_BYTE_PC)) {
>          cpu_stb_data(env, env->sp--, (ret & 0x0000ff));
> -        cpu_stb_data(env, env->sp--, (ret & 0x00ff00) >>  8);
> +        cpu_stb_data(env, env->sp--, (ret & 0x00ff00) >> 8);
>      } else {
>          cpu_stb_data(env, env->sp--, (ret & 0x0000ff));
>      }

These whitespace changes should be squashed into the commit where the
code was added.

thanks
-- PMM