Re: [Qemu-devel] [PATCH v4 12/17] qapi: check invalid arguments on no-args commands

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Hi
>
> On Wed, Aug 17, 2016 at 6:49 PM Markus Armbruster <address@hidden> wrote:
>
>> address@hidden writes:
>>
>> > From: Marc-André Lureau <address@hidden>
>> >
>> > The generated marshal functions do not visit arguments from commands
>> > that take no arguments. Thus they fail to catch invalid
>> > members. Visit the arguments, if provided, to throw an error in case of
>> > invalid members.
>> >
>> > Currently, qmp_check_client_args() checks for invalid arguments and
>> > correctly catches this case. When switching to qmp_dispatch() we want to
>> > keep that behaviour. The commands using 'O' may have arbitrary
>> > arguments, and must have 'gen': false in the qapi schema to skip the
>> > generated checks.
>>
>> Explains why this isn't a bug fix for QMP.  What about QGA?
>>
>
> Sorry, I don't understand what you ask. I thought the above paragraph that
> I added described the current QMP behaviour and why we want to keep it. And
> yes, it'a fix for qga too (it's qapi)

If it *is* a fix for QGA (have you tested it?), the commit message needs
to mention the fact more prominently.  I'll make a suggestion on v5 of
this patch.

[...]