[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit() |
Date: |
Tue, 16 Aug 2016 22:00:18 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Aug 16, 2016 at 08:19:08PM +0800, Fam Zheng wrote:
> On Tue, 08/16 20:17, Peter Xu wrote:
> > > Do we really need error_report_exit when we already have error_fatal?
> >
> > error_fatal is the name of a global var, not the function.
>
> I mean most error_report_exit(...) calls can be converted to
> error_setg(&error_fatal, ...).
Right. But it's just another way to implement error_report_fatal(). We
may still need error_report_fatal() since it's cleaner and shorter
than error_setg(&error_fatal, ...).
-- peterx
- [Qemu-devel] [PATCH 0/2] error-report: introduce error_report_exit(), Peter Xu, 2016/08/11
- [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Peter Xu, 2016/08/11
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Markus Armbruster, 2016/08/16
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Fam Zheng, 2016/08/16
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Peter Xu, 2016/08/16
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Fam Zheng, 2016/08/16
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(),
Peter Xu <=
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Fam Zheng, 2016/08/16
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Markus Armbruster, 2016/08/16
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Peter Xu, 2016/08/17
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Markus Armbruster, 2016/08/17
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Peter Xu, 2016/08/17
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Peter Xu, 2016/08/17
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Markus Armbruster, 2016/08/17
- Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit(), Peter Xu, 2016/08/17
[Qemu-devel] [PATCH 2/2] error-report: leveraging error_report_exit(), Peter Xu, 2016/08/11