[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] correctly handle resize of empty hash tree
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH] correctly handle resize of empty hash tree |
Date: |
Thu, 11 Aug 2016 05:41:22 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Aug 11, 2016 at 10:45:02 +0200, Igor Mammedov wrote:
> On Wed, 10 Aug 2016 17:19:48 +0200
> Paolo Bonzini <address@hidden> wrote:
> > The patch makes sense, but I think we don't need to call qht_reset_size
> > at all.
> >
> > tb_flush should not do anything if using KVM. There are several ways to
> > do this:
> >
> > - put the tb_flush call under "if (tcg_enabled())"
> >
> > - add an "if (!tcg_enabled()) return;" in tb_flush
I like this option the most.
My patch to fix this issue was written thinking that tb_flush was
strangely needed for gdb to work under KVM. If that's not the
case, then let's go for the real fix [above].
Thanks,
E.