[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/3] vhost: check for vhost_ops before using.
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 1/3] vhost: check for vhost_ops before using. |
Date: |
Wed, 10 Aug 2016 18:30:03 +0300 |
From: Ilya Maximets <address@hidden>
'vhost_set_vring_enable()' tries to call function using pointer to
'vhost_ops' which can be already zeroized in 'vhost_dev_cleanup()'
while vhost disconnection.
Fix that by checking 'vhost_ops' before using. This fixes QEMU crash
on calling 'ethtool -L eth0 combined 2' if vhost disconnected.
Signed-off-by: Ilya Maximets <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/net/vhost_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index dc61dc1..f2d49ad 100644
--- a/hw/net/vhost_net.c
+++ b/hw/net/vhost_net.c
@@ -428,7 +428,7 @@ int vhost_set_vring_enable(NetClientState *nc, int enable)
nc->vring_enable = enable;
- if (vhost_ops->vhost_set_vring_enable) {
+ if (vhost_ops && vhost_ops->vhost_set_vring_enable) {
return vhost_ops->vhost_set_vring_enable(&net->dev, enable);
}
--
MST
- [Qemu-devel] [PULL 0/3] virtio/vhost: fixes, Michael S. Tsirkin, 2016/08/10
- [Qemu-devel] [PULL 2/3] vhost-user: Introduce a new protocol feature REPLY_ACK., Michael S. Tsirkin, 2016/08/10
- [Qemu-devel] [PULL 1/3] vhost: check for vhost_ops before using.,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Michael S. Tsirkin, 2016/08/10
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Fam Zheng, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Prerna Saxena, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Marc-André Lureau, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Peter Maydell, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Michael S. Tsirkin, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Peter Maydell, 2016/08/15
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Michael S. Tsirkin, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Marc-André Lureau, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Michael S. Tsirkin, 2016/08/12