Re: [Qemu-devel] [PATCH v2 for-2.7] Update ancient copyright string in -version output

[Eric Blake]

On 08/04/2016 05:14 AM, Peter Maydell wrote:
> Currently the -version command line argument prints a string ending
> with "Copyright (c) 2003-2008 Fabrice Bellard".  This is now some
> eight years out of date; abstract it out of the several places that
> print the string and update it to:
> 
> Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project developers
> 
> to reflect the work by all the QEMU Project contributors over the
> last decade.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> Acked-by: Stefan Hajnoczi <address@hidden>
> ---

Reviewed-by: Eric Blake <address@hidden>

> The aim here is to (1) update the dates and (2) acknowledge
> the work of all our contributors. I'm open to bikeshedding
> on the exact wording (or on which header file we should
> put the #define in...)
> 
> I only pulled out the copyright string proper into the #define
> because a GUI About box is going to want just that, with no
> leading ',' or trailing newline.
> 
> Fabrice: I have cc'd you since this is proposing an update
> to your copyright info.
> 
> v1->v2 changes: add the qemu-img.c string.
> ---
>  bsd-user/main.c       | 3 ++-
>  include/qemu-common.h | 4 ++++
>  linux-user/main.c     | 2 +-
>  qemu-img.c            | 2 +-
>  vl.c                  | 3 ++-
>  5 files changed, 10 insertions(+), 4 deletions(-)

qemu-io has a --version option that probably ought to output copyright
information, but as it currently does not do so, this patch need not be
the one that tweaks it.

qemu-nbd has a --version option, where the copyright info is currently:
Copyright (C) 2006 Anthony Liguori <address@hidden>.

I don't know if we want to rework that one in light of this patch, or if
we can just blindly use this code.  Anthony?

> +/* Copyright string for -version arguments, About dialogs, etc */
> +#define QEMU_COPYRIGHT "Copyright (c) 2003-2016 " \
> +    "Fabrice Bellard and the QEMU Project developers"
> +

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature