[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] virtio-blk: Release s->rq queue at syste
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] virtio-blk: Release s->rq queue at system_reset |
|
Date: |
Thu, 4 Aug 2016 14:42:09 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 03/08/2016 02:52, Fam Zheng wrote:
>> > It's also (perhaps especially) because blk_drain() can consume them. Fam's
>> > patch to do blk_drain() first would cause a double-free.
> That "consume" part is what I don't understand.
>
> Shouldn't blk_drain() only process submitted requests (and further requests
> they dequeue indirectly), while s->rq only contains failed requests.
Nevermind, I was confused. virtio_blk_init_request doesn't store the
requests in a list, unlike SCSI.
Paolo
[Qemu-devel] [PATCH v2 2/2] virtio-blk: Remove stale comment about draining, Fam Zheng, 2016/08/02