Re: [Qemu-devel] [PATCH v3 7/9] tcg: Compress dead_temps and mem_temps into a single array

[Richard Henderson]

On 07/25/2016 08:45 PM, Aurelien Jarno wrote:
> > > +#define TS_DEAD  1
> > > +#define TS_SYNC  2
> I am not sure that TS_SYNC is the best name for that. There we really
> want to tell that at this moment in the TCG instruction stream the
> operand is in memory. It doesn't implied it is synced. Maybe TS_MEM?
>
> The rest looks fine to me. The other alternative would have been to use
> the TCGTempSet with the bitmap functions like in optimize.c, and use
> only 2 bits per temp. That something that can be done later though.

I changed the name to TS_MEM as suggested.


r~