[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] Fix g2h() for 32-bit targets on 64-bit host
|
From: |
Benjamin Herrenschmidt |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] Fix g2h() for 32-bit targets on 64-bit hosts |
|
Date: |
Wed, 03 Aug 2016 20:51:56 +1000 |
On Wed, 2016-08-03 at 11:48 +0100, Peter Maydell wrote:
> > As to why you don't hit the bug on ARM, well, maybe you don't
> > many helpers using tlb_vaddr_to_host ? Also address randomization makes
> > things hit or miss here ...
>
> The only uses of tlb_vaddr_to_host in the tree are
> (a) in a not-CONFIG_USER_ONLY codepath on target-arm
> (b) in target-s390x, which is a 64-bit guest
(c) a few new helpers using it on ppc that are in David's ppc-for-2.8
branch :-)
Now we can put the fix in his branch if you prefer but it's a pretty
trivial one so I would suggest just sticking it in.
Cheers,
Ben