Re: [Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

[Laszlo Ersek]

On 08/01/16 04:53, Fam Zheng wrote:
> This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to
> drain IO requests), remove it.
> 
> Suggested-by: Laszlo Ersek <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  hw/block/virtio-blk.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> index 89eca65..3468a21 100644
> --- a/hw/block/virtio-blk.c
> +++ b/hw/block/virtio-blk.c
> @@ -656,10 +656,6 @@ static void virtio_blk_reset(VirtIODevice *vdev)
>      AioContext *ctx;
>      VirtIOBlockReq *req;
>  
> -    /*
> -     * This should cancel pending requests, but can't do nicely until there
> -     * are per-device request lists.
> -     */
>      ctx = blk_get_aio_context(s->blk);
>      aio_context_acquire(ctx);
>      while (s->rq) {
> 

The thing I mildly dislike about patches that consist purely of code
removal is that they don't show up in "git blame", so it's hard to get
credit for them :) Which is a shame, beacuse code deletion is the best
kind of patch! :)

Reviewed-by: Laszlo Ersek <address@hidden>

Cheers!
Laszlo