[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] optionrom: fix detection of -Wa,-32
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] optionrom: fix detection of -Wa,-32 |
|
Date: |
Fri, 29 Jul 2016 14:22:41 +0100 |
On 20 July 2016 at 20:36, Paolo Bonzini <address@hidden> wrote:
> The cc-option macro runs $(CC) in -S mode (generate assembly) to avoid a
> pointless run of the assembler. However, this does not work when you want
> to detect support for cc->as option passthrough. clang ignores -Wa unless
> -c is provided, and exits successfully even if the -Wa,-32 option is not
> supported.
>
> Reported-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
Applied to master, thanks (since it fixes BSD builds).
-- PMM