Re: [Qemu-devel] [PATCH v1 5/8] target-ppc: add vcmpnez[b, h, w][.] instructions

[Richard Henderson]

On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote:
> +#define VCMPNEZ_DO(suffix, element, record)                         \
> +void helper_vcmpnez##suffix(CPUPPCState *env, ppc_avr_t *r,         \
> +                            ppc_avr_t *a, ppc_avr_t *b)                 \
> +{                                                                       \
> +    uint64_t ones = (uint64_t)-1;                                       \
> +    uint64_t all = ones;                                                \
> +    uint64_t none = 0;                                                  \
> +    int i;                                                              \
> +                                                                        \
> +    for (i = 0; i < ARRAY_SIZE(r->element); i++) {                      \
> +        uint64_t result = ((a->element[i] == 0)                         \
> +                           || (b->element[i] == 0)                      \
> +                           || (a->element[i] != b->element[i]) ?        \
> +                           ones : 0x0);                                 \

Don't you have the proper type to use, as opposed to widening everything to 
uint64_t?  I would guess element##_t would do the job.


r~