[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] util: fix some coding style issue

From: Cao jin
Subject: Re: [Qemu-devel] [PATCH 2/3] util: fix some coding style issue
Date: Thu, 28 Jul 2016 16:44:47 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 07/28/2016 04:08 PM, Daniel P. Berrange wrote:
On Thu, Jul 28, 2016 at 03:39:30PM +0800, Cao jin wrote:
Fix some coding style issues found in removing NonBlockingConnectHandler.

Cc: Daniel P. Berrange <address@hidden>
Cc: Gerd Hoffmann <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Signed-off-by: Cao jin <address@hidden>
  util/qemu-sockets.c | 16 +++++++++++-----
  1 file changed, 11 insertions(+), 5 deletions(-)

Reviwed-by: Daniel P. Berrange <address@hidden>

@@ -443,12 +443,16 @@ static int inet_dgram_saddr(InetSocketAddress *sraddr,
      return sock;

-    if (-1 != sock)
+    if (-1 != sock) {

I'd probably fix the yoda-conditional here too. ie sock != -1 instead.

Just find this file mixes yoda-condition and non-yoda-condition.
ok, I can do it, v2 on the way.

Yours Sincerely,

Cao jin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]