[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/6] arm: add support for an ast2500 evaluation

From: Cédric Le Goater
Subject: Re: [Qemu-devel] [PATCH 6/6] arm: add support for an ast2500 evaluation board
Date: Thu, 28 Jul 2016 10:03:52 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0

On 07/28/2016 09:58 AM, Andrew Jeffery wrote:
> On Thu, 2016-07-28 at 09:15 +0200, Cédric Le Goater wrote:
>>> Also, the meaning of the bits have changed from the AST2400 - they
>>> probably should be documented somewhere?
>> So you want me send to an updated version of :
>>         http://lists.nongnu.org/archive/html/qemu-arm/2016-06/msg00698.html
>> as a prereq ? 
> I mentioned this in passing due to the discussion on my original patch.
> I think we discussed this separately and concluded the macros were
> pretty verbose given they are sort-of single-use given the value
> doesn't change. Maybe just comments as Peter was requesting? You have
> the patch below but some of the macros will be different for the
> AST2500.


> I'm probably leaning towards comments over macros, but don't feel
> strongly either way.

ok. having a correct value is a minimum and this is not the case 
in this patch. I think I will go for the comments for now as We 
have not merged anything in mainline uboot yet.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]