[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH V3 0/3] filter-rewriter: introduce filter-re

From: Zhang Chen
Subject: Re: [Qemu-devel] [RFC PATCH V3 0/3] filter-rewriter: introduce filter-rewriter
Date: Wed, 27 Jul 2016 13:49:55 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 07/27/2016 10:50 AM, Jason Wang wrote:

On 2016年07月27日 10:32, Zhang Chen wrote:
Hi~ all~~

Anyone have some comments for this series?

Will have a look at this.

Btw. I wonder how this is tested, do we need a unit test for this?

COLO-compare and filter-rewriter works normal depend on colo-frame.
So, When colo-frame be merged I will send a colo-proxy unit test
for all filter-mirror,filter-redirector,colo-compare,filter-rewriter.

We need more comments to improve COLO codes.


Zhang Chen

On 07/05/2016 06:29 PM, Zhang Chen wrote:
Filter-rewriter is a part of COLO project.
So this patch set depend on colo-compare.

Interesting, I thought it can co-work with comparing, and the communication were done through socket now. So I think technically the filter itself could work without COLO?

Filter-rewriter can run without COLO, but it no sense for other people.
rewriter need TX tcp packet differ with RX tcp packet...
In normal qemu we can't get the environment same with COLO.

It will rewrite some of secondary packet to make
secondary guest's connection established successfully.
In this module we will rewrite tcp packet's ack to the secondary
from primary,and rewrite tcp packet's seq to the primary from

   - fix typo
   - add conn->syn_flag
   - add some comments
   - remove conn_list_lock
   - fix offset set bug

I think you can remove RFC in the next version so we can try to merge it after one or several other iterations.

OK~~ I will remove RFC in colo-compare and filter-rewriter.

Thanks for your review~~
Zhang Chen


   - add more comments about packet flows
   - add some trace-event
   - add seq offset ( = secondary_seq - primary_seq)

   - initial patch

Zhang Chen (3):
   filter-rewriter: introduce filter-rewriter initialization
   filter-rewriter: track connection and parse packet
   filter-rewriter: rewrite tcp packet to keep secondary connection

  net/Makefile.objs     |   1 +
  net/colo-base.c       |   2 +
  net/colo-base.h       |   7 ++
net/filter-rewriter.c | 262 ++++++++++++++++++++++++++++++++++++++++++++++++++
  qemu-options.hx       |  13 +++
  trace-events          |   5 +
  vl.c                  |   3 +-
  7 files changed, 292 insertions(+), 1 deletion(-)
  create mode 100644 net/filter-rewriter.c



reply via email to

[Prev in Thread] Current Thread [Next in Thread]