[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/32] ppc: Make float_check_status() pass the r
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [PATCH 10/32] ppc: Make float_check_status() pass the return address |
Date: |
Wed, 27 Jul 2016 13:47:59 +1000 |
On Wed, 2016-07-27 at 11:57 +1000, David Gibson wrote:
> > -void helper_float_check_status(CPUPPCState *env)
> > +static __attribute__((noinline)) void
> do_float_check_status(CPUPPCState *env,
> > +
> uintptr_t raddr)
>
> Why do you need to force this to be non-inline?
I don't. It just that gcc inlines too much shit :-)
In fact I had a patch at some point that made a whole pile of stuff in
translate.c non-inline and that reduced the size of it by about 100K
But yeah, I can drop it for now, it's irrelevant to the point of the
patch.
Cheers,
ben.
- [Qemu-devel] [PATCH 09/32] ppc: Make float_invalid_op_excp() pass the return address, (continued)
- [Qemu-devel] [PATCH 09/32] ppc: Make float_invalid_op_excp() pass the return address, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 04/32] ppc: Move embedded spe ops out of translate.c, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 15/32] ppc: Make tlb_fill() use new exception helper, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 13/32] ppc: Don't update NIP in lswi/lswx/stswi/stswx, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 10/32] ppc: Make float_check_status() pass the return address, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 03/32] ppc: Move classic fp ops out of translate.c, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 08/32] ppc: Rename fload_invalid_op_excp to float_invalid_op_excp, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 06/32] ppc: Move VMX ops out of translate.c, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 11/32] ppc: Don't update the NIP in floating point generated code, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 07/32] ppc: Move VSX ops out of translate.c, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 12/32] ppc: FP exceptions are always precise, Benjamin Herrenschmidt, 2016/07/26