[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 4/7] scripts: refactor the VM class in iotests fo
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PULL 4/7] scripts: refactor the VM class in iotests for reuse |
Date: |
Tue, 26 Jul 2016 09:24:20 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, Jul 26, 2016 at 02:23:52AM +0200, Max Reitz wrote:
> On 22.07.2016 10:00, Amit Shah wrote:
> > From: "Daniel P. Berrange" <address@hidden>
> >
> > The iotests module has a python class for controlling QEMU
> > processes. Pull the generic functionality out of this file
> > and create a scripts/qemu.py module containing a QEMUMachine
> > class. Put the QTest integration support into a subclass
> > QEMUQtestMachine.
> >
> > Signed-off-by: Daniel P. Berrange <address@hidden>
> > Message-Id: <address@hidden>
> > Signed-off-by: Amit Shah <address@hidden>
> > ---
> > scripts/qemu.py | 202
> > ++++++++++++++++++++++++++++++++++++++++++
> > scripts/qtest.py | 34 +++++++
> > tests/qemu-iotests/iotests.py | 135 +---------------------------
> > 3 files changed, 240 insertions(+), 131 deletions(-)
> > create mode 100644 scripts/qemu.py
>
> Hm, I have even more questions...
>
> (I'm starting to wonder if I'm doing anything horribly wrong, because
> this patch basically completely breaks the Python iotests for me.)
[snip]
I'll investigate this and send any neccessary fixes asap.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PULL 0/7] migration: fix, perf testing framework, Amit Shah, 2016/07/22
- [Qemu-devel] [PULL 1/7] migration: set state to post-migrate on failure, Amit Shah, 2016/07/22
- [Qemu-devel] [PULL 2/7] scripts: add __init__.py file to scripts/qmp/, Amit Shah, 2016/07/22
- [Qemu-devel] [PULL 3/7] scripts: add a 'debug' parameter to QEMUMonitorProtocol, Amit Shah, 2016/07/22
- [Qemu-devel] [PULL 4/7] scripts: refactor the VM class in iotests for reuse, Amit Shah, 2016/07/22
- [Qemu-devel] [PULL 5/7] scripts: set timeout when waiting for qemu monitor connection, Amit Shah, 2016/07/22
- [Qemu-devel] [PULL 6/7] scripts: ensure monitor socket has SO_REUSEADDR set, Amit Shah, 2016/07/22
- [Qemu-devel] [PULL 7/7] tests: introduce a framework for testing migration performance, Amit Shah, 2016/07/22
- Re: [Qemu-devel] [PULL 0/7] migration: fix, perf testing framework, Peter Maydell, 2016/07/22