Re: [Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary internal msi state flag

[Cao jin]

On 07/26/2016 01:01 PM, Amit Shah wrote:
> On (Tue) 05 Jul 2016 [18:47:40], Michael S. Tsirkin wrote:
> > From: Cao jin <address@hidden>
> >
> > internal flag msi_in_use in unnecessary, msi_uninit() could be called
> > directly, and msi_enabled() is enough to check device msi state.
> >
> > cc: Markus Armbruster <address@hidden>
> > cc: Marcel Apfelbaum <address@hidden>
> > cc: Paolo Bonzini <address@hidden>
> > cc: Michael S. Tsirkin <address@hidden>
> >
> > Reviewed-by: Markus Armbruster <address@hidden>
> > Signed-off-by: Cao jin <address@hidden>
> > Reviewed-by: Michael S. Tsirkin <address@hidden>
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
>
> [...]
>
> >   static void mptsas_reset(DeviceState *dev)
> > @@ -1375,7 +1370,6 @@ static const VMStateDescription vmstate_mptsas = {
> >       .post_load = mptsas_post_load,
> >       .fields      = (VMStateField[]) {
> >           VMSTATE_PCI_DEVICE(dev, MPTSASState),
> > -        VMSTATE_BOOL(msi_in_use, MPTSASState),
>
> This removes vmstate -- please use 'unused' instead of removing this
> value.
>
> Flagged by the static checker.

Hi Amit

I will take care of this.
BTW, did't see it in coverity scan outstanding defects, Do I missed or 
it is checked by other static check tools?
--
Yours Sincerely,

Cao jin