[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ? |
Date: |
Sun, 24 Jul 2016 22:52:25 +1000 |
On Sun, 2016-07-24 at 22:51 +1000, Benjamin Herrenschmidt wrote:
>
> FYI: This probably completely wrong patch (but it was easier than
> hacking all the helpers) fixed the problem for me. With this (and the
> video driver I wrote that I will publish asap), I can now reliably
> boot
> various versions of MacOS X in qemu ppc using a 7400 CPU.
And here's the patch:
diff --git a/include/exec/cpu_ldst_template.h b/include/exec/cpu_ldst_template.h
index eaf69a1..13e8881 100644
--- a/include/exec/cpu_ldst_template.h
+++ b/include/exec/cpu_ldst_template.h
@@ -111,7 +111,7 @@ glue(glue(glue(cpu_ld, USUFFIX), MEMSUFFIX),
_ra)(CPUArchState *env,
static inline RES_TYPE
glue(glue(cpu_ld, USUFFIX), MEMSUFFIX)(CPUArchState *env, target_ulong ptr)
{
- return glue(glue(glue(cpu_ld, USUFFIX), MEMSUFFIX), _ra)(env, ptr, 0);
+ return glue(glue(glue(cpu_ld, USUFFIX), MEMSUFFIX), _ra)(env, ptr,
GETPC());
}
#if DATA_SIZE <= 2
@@ -149,7 +149,7 @@ glue(glue(glue(cpu_lds, SUFFIX), MEMSUFFIX),
_ra)(CPUArchState *env,
static inline int
glue(glue(cpu_lds, SUFFIX), MEMSUFFIX)(CPUArchState *env, target_ulong ptr)
{
- return glue(glue(glue(cpu_lds, SUFFIX), MEMSUFFIX), _ra)(env, ptr, 0);
+ return glue(glue(glue(cpu_lds, SUFFIX), MEMSUFFIX), _ra)(env, ptr,
GETPC());
}
#endif
@@ -191,7 +191,7 @@ static inline void
glue(glue(cpu_st, SUFFIX), MEMSUFFIX)(CPUArchState *env, target_ulong ptr,
RES_TYPE v)
{
- glue(glue(glue(cpu_st, SUFFIX), MEMSUFFIX), _ra)(env, ptr, v, 0);
+ glue(glue(glue(cpu_st, SUFFIX), MEMSUFFIX), _ra)(env, ptr, v, GETPC());
}
#endif /* !SOFTMMU_CODE_ACCESS */
- [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?, Benjamin Herrenschmidt, 2016/07/24
- Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?, Benjamin Herrenschmidt, 2016/07/24
- Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?,
Benjamin Herrenschmidt <=
- Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?, Richard Henderson, 2016/07/24
- Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?, Benjamin Herrenschmidt, 2016/07/24
- Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?, Benjamin Herrenschmidt, 2016/07/24
- Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?, Richard Henderson, 2016/07/25
- Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?, Benjamin Herrenschmidt, 2016/07/25
- Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?, Peter Maydell, 2016/07/25
- Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?, Benjamin Herrenschmidt, 2016/07/25
- Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?, Benjamin Herrenschmidt, 2016/07/25
Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?, Richard Henderson, 2016/07/24