[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Symlink README.md as README to unbreak checkpat
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH] Symlink README.md as README to unbreak checkpatch.pl |
Date: |
Wed, 20 Jul 2016 20:35:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 |
On 07/20/16 20:07, John Snow wrote:
> On 07/20/2016 08:31 AM, Eric Blake wrote:
>> On 07/20/2016 04:48 AM, Stefan Weil wrote:
>>> Am 20.07.2016 um 12:36 schrieb Peter Maydell:
>>>> On 20 July 2016 at 08:27, Fam Zheng <address@hidden> wrote:
>>>>> Commit e5dfc5e8e71 renamed README to README.md but
>>>>> scripts/checkpatch.pl still looks for the old name to sanity check
>>>>> that it's invoked from the toplevel of tree. Create a symbol link to
>>>>> README.md to fix that. I've verified that on github README.md still
>>>>> takes precedence and page is rendered.
>>>> Have you checked that the symlink does sensible things if the git tree
>>>> is checked out under Windows? thanks -- PMM
>>>
>>>
>>> ... and that the Windows installer will get a working README, not only a
>>> symlink?
>>> You could move README.md to README and link that to README.md
>>> (as suggested by Paolo) - that would avoid such problems.
>>
>> I would favor README as the real file, and README.md as the symlink. The
>
> Will Github DTRT?
Well, I don't know whether GitHub will always do the right thing,
but in this case it does, see my test here:
https://github.com/stweil/qemu/tree/readme
Stefan
Re: [Qemu-devel] [PATCH] Symlink README.md as README to unbreak checkpatch.pl, Stefan Hajnoczi, 2016/07/20