Re: [Qemu-devel] [PATCH V2] hw/virtio-pci: fix virtio behaviour on modern (PCIe) machines

[Gerd Hoffmann]

> > Notes:
> >    - The non PCIe machines behaviour should remain the same.
> >    - I hope is OK to make the disable-* properties OnOffAuto. Previous 
> > setups
> >      using them can be affected,
> 
> why? could you explain pls? isn't onoffauto compatible with bit
> properties?

I have the same question ;)

> Also, I wonder how does this interact with devices that play with
> these flags themselves, like virtio gpu?

virtio input forces virtio 1.0 only too.
I think they must be changed to set the new property variables instead.

> I guess we could just set VIRTIO_PCI_FLAG_DISABLE_LEGACY, avoid clearing it.

I think we should simply drop the flags and use bool variables instead.

Also while being at it:  Should we enable modern by default for all pci
devices?

cheers,
  Gerd