[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 25/37] ahci: free irqs array
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH 25/37] ahci: free irqs array |
Date: |
Tue, 19 Jul 2016 14:50:27 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 07/19/2016 04:54 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> Each irq is referenced by the IDEBus in ide_init2(), thus we can free
> the no longer used array.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> hw/ide/ahci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index bcb9ff9..6defeed 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -1478,6 +1478,7 @@ void ahci_realize(AHCIState *s, DeviceState *qdev,
> AddressSpace *as, int ports)
> ad->port.dma->ops = &ahci_dma_ops;
> ide_register_restart_cb(&ad->port);
> }
> + g_free(irqs);
> }
>
> void ahci_uninit(AHCIState *s)
>
Oh, we pass these by-value, so yes.
Reviewed-by: John Snow <address@hidden>
And if this entire series gets picked up, have an ACK to mean "I don't
care who stages this:"
Acked-by: John Snow <address@hidden>
- Re: [Qemu-devel] [PATCH 21/37] tests: fix qom-test leaks, (continued)
[Qemu-devel] [PATCH 25/37] ahci: free irqs array, marcandre . lureau, 2016/07/19
- Re: [Qemu-devel] [PATCH 25/37] ahci: free irqs array,
John Snow <=
[Qemu-devel] [PATCH 26/37] sd: free timer, marcandre . lureau, 2016/07/19
[Qemu-devel] [PATCH 27/37] qjson: free str, marcandre . lureau, 2016/07/19
[Qemu-devel] [PATCH 28/37] virtio-input: free config list, marcandre . lureau, 2016/07/19
[Qemu-devel] [PATCH 29/37] ipmi: free extern timer, marcandre . lureau, 2016/07/19