[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drive
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers |
Date: |
Tue, 19 Jul 2016 16:06:04 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, Jul 19, 2016 at 04:42:38PM +0200, Paolo Bonzini wrote:
>
>
> On 19/07/2016 15:47, Colin Lord wrote:
> > However, the protocol drivers do tend to see noticeable performance
> > benefits. Most of them get modularized in the first three patches of
> > this series. This includes the iscsi, glusterfs, ssh, curl, and rbd
> > drivers.
>
> Indeed, but... protocol drivers don't have probes, do they? There is a
> distinction between "formats" and "protocols", and only formats need to
> be probed for.
IOW, if we only modularized the protocol drivers, then there's no
reason to split out the probe code to separate files, so we avoid
a whole lot of code churn, and keep all the format drivers largely
self contained as today which would be nice.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v4 30/32] blockdev: Remove the .bdrv_probe field from BlockDrivers, (continued)
- [Qemu-devel] [PATCH v4 30/32] blockdev: Remove the .bdrv_probe field from BlockDrivers, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 23/32] blockdev: Separate qcow2 probe from its driver, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 18/32] blockdev: Separate cloop probe from its driver, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 22/32] blockdev: Separate qcow probe from its driver, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 32/32] blockdev: Remove bdrv_probe_device field from BlockDriver, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 29/32] blockdev: Separate vpc probe from its driver, Colin Lord, 2016/07/14
- [Qemu-devel] [PATCH v4 28/32] blockdev: Separate vmdk probe from its driver, Colin Lord, 2016/07/14
- Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers, Paolo Bonzini, 2016/07/19
- Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers, Max Reitz, 2016/07/22