[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 06/14] nbd: Send message along with server NB
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v5 06/14] nbd: Send message along with server NBD_REP_ERR errors |
Date: |
Tue, 19 Jul 2016 13:15:33 +0800 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Mon, 07/18 22:07, Eric Blake wrote:
> nbd/server.c | 78
> +++++++++++++++++++++++++++++++++++++++++++++---------------
> 1 file changed, 59 insertions(+), 19 deletions(-)
>
> diff --git a/nbd/server.c b/nbd/server.c
> index c8716f1..ad31c4a 100644
> --- a/nbd/server.c
> +++ b/nbd/server.c
> @@ -235,6 +235,38 @@ static int nbd_negotiate_send_rep(QIOChannel *ioc,
> uint32_t type, uint32_t opt)
> return nbd_negotiate_send_rep_len(ioc, type, opt, 0);
> }
>
> +/* Send an error reply.
> + * Return -errno to kill connection, 0 to continue negotiation. */
> +static int GCC_FMT_ATTR(4, 5)
> + nbd_negotiate_send_rep_err(QIOChannel *ioc, uint32_t type,
Isn't the function name supposed to be place at col 0?
> + uint32_t opt, const char *fmt, ...)
- Re: [Qemu-devel] [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server, (continued)
[Qemu-devel] [PATCH v5 11/14] nbd: Support shorter handshake, Eric Blake, 2016/07/19
[Qemu-devel] [PATCH v5 14/14] nbd: Implement NBD_CMD_WRITE_ZEROES on client, Eric Blake, 2016/07/19
[Qemu-devel] [PATCH v5 07/14] nbd: Share common option-sending code in client, Eric Blake, 2016/07/19
[Qemu-devel] [PATCH v5 06/14] nbd: Send message along with server NBD_REP_ERR errors, Eric Blake, 2016/07/19
- Re: [Qemu-devel] [PATCH v5 06/14] nbd: Send message along with server NBD_REP_ERR errors,
Fam Zheng <=
[Qemu-devel] [PATCH v5 05/14] nbd: Share common reply-sending code in server, Eric Blake, 2016/07/19
[Qemu-devel] [PATCH v5 02/14] nbd: Add qemu-nbd -D for human-readable description, Eric Blake, 2016/07/19
[Qemu-devel] [PATCH v5 04/14] nbd: Treat flags vs. command type as separate fields, Eric Blake, 2016/07/19
[Qemu-devel] [PATCH v5 12/14] nbd: Improve server handling of shutdown requests, Eric Blake, 2016/07/19
[Qemu-devel] [PATCH v5 10/14] nbd: Less allocation during NBD_OPT_LIST, Eric Blake, 2016/07/19
Re: [Qemu-devel] [PATCH for-2.7 v5 00/14] nbd: efficient write zeroes, Fam Zheng, 2016/07/19
Re: [Qemu-devel] [PATCH for-2.7 v5 00/14] nbd: efficient write zeroes, Paolo Bonzini, 2016/07/19