Re: [Qemu-devel] [PATCH] usb-mtp: added support for files larger than 4gb

[Isaac Lozano]

>> @@ -72,6 +76,22 @@ enum mtp_code {
>>      EVT_OBJ_ADDED                  = 0x4002,
>>      EVT_OBJ_REMOVED                = 0x4003,
>>      EVT_OBJ_INFO_CHANGED           = 0x4007,
>> +
>> +    /* object properties */
>> +    PROP_STORAGE_ID                = 0xDC01,
>> +    PROP_OBJECT_FORMAT             = 0xDC02,
>> +    PROP_OBJECT_COMPRESSED_SIZE    = 0xDC04,
>> +    PROP_PARENT_OBJECT             = 0xDC0B,
>
> Is prop_parent_object required to be supported ? What does it exactly
> do ?

It's a required property. It returns the handle for the object that contains
the file. Basically the handle for the directory the file is in.

> What about the case when initiator requests a property
> not implemented ? Reponder should be returning back a specific error
> code right ?
>
> Bandan

Yes it should. Replacing the RES_GENERAL_ERROR with
RES_INVALID_OBJECT_PROP_CODE (after adding it to the enum) should fix
that.

I'll get a v2 in soon.

- Isaac Lozano