[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 11/15] block: simplify blockdev-backup
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 11/15] block: simplify blockdev-backup |
Date: |
Thu, 14 Jul 2016 06:37:24 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/04/2016 06:28 AM, Denis V. Lunev wrote:
> From: Pavel Butsykin <address@hidden>
>
> Now that we can support boxed commands, use it to greatly reduce the
> number of parameters (and likelihood of getting out of sync) when
> adjusting blockdev-backup parameters.
>
> Signed-off-by: Pavel Butsykin <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Eric Blake <address@hidden>
> CC: John Snow <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> ---
> blockdev.c | 65
> +++++++++++++++-------------------------------------
> qapi/block-core.json | 6 ++++-
> 2 files changed, 24 insertions(+), 47 deletions(-)
>
> +++ b/qapi/block-core.json
> @@ -1088,9 +1088,13 @@
> #
> # For the arguments, see the documentation of BlockdevBackup.
> #
> +# Returns: nothing on success
> +# If @device is not a valid block device, DeviceNotFound
> +#
> # Since 2.3
> ##
> -{ 'command': 'blockdev-backup', 'data': 'BlockdevBackup' }
> +{ 'command': 'blockdev-backup', 'box': true,
> + 'data': 'BlockdevBackup' }
Will need a trivial rebase; my pending qapi v9 patches renamed the new
parameter 'boxed' instead of 'box'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v5 07/15] qcow: cleanup qcow_co_pwritev_compressed to avoid the recursion, (continued)
- [Qemu-devel] [PATCH v5 07/15] qcow: cleanup qcow_co_pwritev_compressed to avoid the recursion, Denis V. Lunev, 2016/07/04
- [Qemu-devel] [PATCH v5 08/15] block: remove BlockDriver.bdrv_write_compressed, Denis V. Lunev, 2016/07/04
- [Qemu-devel] [PATCH v5 09/15] block/io: turn on dirty_bitmaps for the compressed writes, Denis V. Lunev, 2016/07/04
- [Qemu-devel] [PATCH v5 10/15] block: simplify drive-backup, Denis V. Lunev, 2016/07/04
- [Qemu-devel] [PATCH v5 11/15] block: simplify blockdev-backup, Denis V. Lunev, 2016/07/04
- [Qemu-devel] [PATCH v5 12/15] drive-backup: added support for data compression, Denis V. Lunev, 2016/07/04
- [Qemu-devel] [PATCH v5 14/15] qemu-iotests: test backup compression in 055, Denis V. Lunev, 2016/07/04
- [Qemu-devel] [PATCH v5 13/15] blockdev-backup: added support for data compression, Denis V. Lunev, 2016/07/04
- [Qemu-devel] [PATCH v5 15/15] qemu-iotests: add vmdk for test backup compression in 055, Denis V. Lunev, 2016/07/04
- Re: [Qemu-devel] [PATCH v5 00/15] backup compression, Denis V. Lunev, 2016/07/08
- Re: [Qemu-devel] [PATCH v5 00/15] backup compression, Jeff Cody, 2016/07/19