Re: [Qemu-devel] [Qemu-block] [PATCH 1/3] iotests: Add dmg format option

[John Snow]

On 07/11/2016 03:50 PM, Colin Lord wrote:
> Adds option to test the dmg format.
> 
> Signed-off-by: Colin Lord <address@hidden>
> ---
>  tests/qemu-iotests/common | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
> index d60ea2c..dc937c7 100644
> --- a/tests/qemu-iotests/common
> +++ b/tests/qemu-iotests/common
> @@ -140,6 +140,7 @@ common options
>  
>  check options
>      -raw                test raw (default)
> +    -dmg                test dmg
>      -bochs              test bochs
>      -cloop              test cloop
>      -parallels          test parallels
> @@ -181,6 +182,12 @@ testlist options
>              xpand=false
>              ;;
>  
> +        -dmg)
> +            IMGFMT=dmg
> +            IMGFMT_GENERIC=false
> +            xpand=false
> +            ;;
> +
>          -bochs)
>              IMGFMT=bochs
>              IMGFMT_GENERIC=false
> 

Non-controversial, but a little scant on substance :)

Not run: 001 002 003 004 005 007 008 009 010 011 012 013 014 015 017 018
019 020 021 022 023 024 025 026 027 028 029 030 031 032 033 034 035 036
037 038 039 040 041 042 043 044 045 046 047 048 049 050 051 052 053 054
055 056 057 058 059 060 061 062 063 064 065 066 067 068 069 070 071 072
073 074 075 076 077 078 079 080 081 082 083 084 085 086 087 088 089 090
091 092 093 094 095 096 097 098 099 101 102 103 104 105 107 108 109 110
111 112 113 114 115 116 117 118 119 120 121 122 123 124 128 129 130 131
132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 148 149 150
152 154 155 156
Passed all 0 tests

Ah, perfect!

Reviewed-by: John Snow <address@hidden>