[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is adde
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added. |
Date: |
Tue, 12 Jul 2016 10:19:11 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 07/06/2016 03:33 PM, Michael Rolnik wrote:
> +static bool avr_cpu_has_work(CPUState *cs)
> +{
> + AVRCPU *cpu = AVR_CPU(cs);
> + CPUAVRState *env = &cpu->env;
> +
> + return (cs->interrupt_request
> + & (CPU_INTERRUPT_HARD
> + | CPU_INTERRUPT_RESET))
> + && cpu_interrupts_enabled(env);
> +}
> +static void avr_cpu_synchronize_from_tb(CPUState *cs, TranslationBlock *tb)
> +{
> + AVRCPU *cpu = AVR_CPU(cs);
> + CPUAVRState *env = &cpu->env;
> +
> + env->pc_w = tb->pc / 2; /* internally PC points to words */
> +}
For the 4th time: missing spaces between functions. Lots of them. Please fix
them all, without me having to repeat myself a 5th time.
> + bool fullacc;/* CPU/MEM if true MEM only otherwise */
...
> +static inline void cpu_get_tb_cpu_state(CPUAVRState *env, target_ulong *pc,
> + target_ulong *cs_base, uint32_t *pflags)
> +{
> + *pc = env->pc_w * 2;
> + *cs_base = 0;
> + *pflags = 0;
> +}
The fullacc bit needs to be reflected in *pflags here. The way you are
accessing env->fullacc from translate*.c is invalid.
r~
- [Qemu-devel] [PATCH v10 00/10] *** 8bit AVR cores ***, Michael Rolnik, 2016/07/06
- [Qemu-devel] [PATCH v10 02/10] target-avr: adding AVR CPU features/flavors, Michael Rolnik, 2016/07/06
- [Qemu-devel] [PATCH v10 03/10] target-avr: adding a sample AVR board, Michael Rolnik, 2016/07/06
- [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added., Michael Rolnik, 2016/07/06
- Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added.,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added., Michael Rolnik, 2016/07/12
- Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added., Richard Henderson, 2016/07/13
- Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added., Michael Rolnik, 2016/07/13
- Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added., Michael Rolnik, 2016/07/13
- Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added., Richard Henderson, 2016/07/13
[Qemu-devel] [PATCH v10 05/10] target-avr: adding AVR interrupt handling, Michael Rolnik, 2016/07/06
[Qemu-devel] [PATCH v10 06/10] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions, Michael Rolnik, 2016/07/06
[Qemu-devel] [PATCH v10 04/10] target-avr: adding instructions encodings, Michael Rolnik, 2016/07/06
[Qemu-devel] [PATCH v10 07/10] target-avr: adding instruction decoder, Michael Rolnik, 2016/07/06