|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PULL 08/14] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW) |
| Date: | Mon, 11 Jul 2016 16:21:29 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 05/07/2016 07:31, David Gibson wrote:
>
> - if (tcet && tcet->nb_table) {
> - spapr_tce_table_disable(tcet);
> + if (tcet && tcet->nb_table) {
> + spapr_tce_table_disable(tcet);
> + }
> }
>
> /* Register default 32bit DMA window */
> + tcet = spapr_tce_find_by_liobn(sphb->dma_liobn[0]);
Should the statement below be wrapped by "if (tcet)"?
Paolo
> spapr_tce_table_enable(tcet, SPAPR_TCE_PAGE_SHIFT, sphb->dma_win_addr,
> sphb->dma_win_size >> SPAPR_TCE_PAGE_SHIFT)
| [Prev in Thread] | Current Thread | [Next in Thread] |