[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/5] fsdev/9p-iov-marshal.c: Don't use cpu_to_*w(
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH v2 1/5] fsdev/9p-iov-marshal.c: Don't use cpu_to_*w() functions |
Date: |
Thu, 7 Jul 2016 17:20:56 +0100 |
Don't use the cpu_to_*w() functions, which we are trying to deprecate.
Instead just use cpu_to_*() to do the byteswap, which brings the
code in the marshal function in line with that in the unmarshal.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
fsdev/9p-iov-marshal.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/fsdev/9p-iov-marshal.c b/fsdev/9p-iov-marshal.c
index 584082b..663cad5 100644
--- a/fsdev/9p-iov-marshal.c
+++ b/fsdev/9p-iov-marshal.c
@@ -207,31 +207,25 @@ ssize_t v9fs_iov_vmarshal(struct iovec *in_sg, int
in_num, size_t offset,
break;
}
case 'w': {
- uint16_t val;
+ uint16_t val = va_arg(ap, int);
if (bswap) {
- cpu_to_le16w(&val, va_arg(ap, int));
- } else {
- val = va_arg(ap, int);
+ val = cpu_to_le16(val);
}
copied = v9fs_pack(in_sg, in_num, offset, &val, sizeof(val));
break;
}
case 'd': {
- uint32_t val;
+ uint32_t val = va_arg(ap, uint32_t);
if (bswap) {
- cpu_to_le32w(&val, va_arg(ap, uint32_t));
- } else {
- val = va_arg(ap, uint32_t);
+ val = cpu_to_le32(val);
}
copied = v9fs_pack(in_sg, in_num, offset, &val, sizeof(val));
break;
}
case 'q': {
- uint64_t val;
+ uint64_t val = va_arg(ap, uint64_t);
if (bswap) {
- cpu_to_le64w(&val, va_arg(ap, uint64_t));
- } else {
- val = va_arg(ap, uint64_t);
+ val = cpu_to_le64(val);
}
copied = v9fs_pack(in_sg, in_num, offset, &val, sizeof(val));
break;
--
1.9.1
- [Qemu-devel] [PATCH v2 0/5] Drop cpu_to_*w, *_to_cpup, document cpu_to_*, *_to_cpu, Peter Maydell, 2016/07/07
- [Qemu-devel] [PATCH v2 5/5] bswap.h: Document cpu_to_* and *_to_cpu conversion functions, Peter Maydell, 2016/07/07
- [Qemu-devel] [PATCH v2 1/5] fsdev/9p-iov-marshal.c: Don't use cpu_to_*w() functions,
Peter Maydell <=
- [Qemu-devel] [PATCH v2 4/5] bswap.h: Fix comment typo, Peter Maydell, 2016/07/07
- [Qemu-devel] [PATCH v2 3/5] bswap.h: Remove unused cpu_to_*w() and *_to_cpup(), Peter Maydell, 2016/07/07
- [Qemu-devel] [PATCH v2 2/5] hw/bt: Don't use cpu_to_*w() and *_to_cpup(), Peter Maydell, 2016/07/07
- Re: [Qemu-devel] [PATCH v2 0/5] Drop cpu_to_*w, *_to_cpup, document cpu_to_*, *_to_cpu, Peter Maydell, 2016/07/12