[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: Correct type for LOOP_GET_STATUS{,
|
From: |
Chanho Park |
|
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: Correct type for LOOP_GET_STATUS{, 64} ioctls |
|
Date: |
Thu, 7 Jul 2016 15:27:54 +0900 |
Hi Peter,
On Wednesday, July 6, 2016, Peter Maydell <address@hidden> wrote:
> The LOOP_GET_STATUS and LOOP_GET_STATUS64 ioctls were incorrectly
> defined as IOC_W rather than IOC_R, which meant we weren't
> correctly copying the information back from the kernel to the guest.
> The loop_info64 structure definition was also missing a member
> and using the wrong type for several 32-bit fields.
>
> In particular, this meant that "kpartx -d image.img" didn't work
> and "losetup -a" behaved strangely. Correct the ioctl type definitions.
>
> Reported-by: Chanho Park <address@hidden <javascript:;>>
> Signed-off-by: Peter Maydell <address@hidden <javascript:;>>
> ---
It worked well for me.
Tested-by: Chanho Park <address@hidden>
>
--
Best Regards,
Chanho Park