Re: [Qemu-devel] [PATCH] main-loop: check return value before using

[Fam Zheng]

On Wed, 07/06 15:46, Cao jin wrote:
> 
> On 07/06/2016 02:46 PM, Fam Zheng wrote:
> > On Wed, 07/06 11:03, Cao jin wrote:
> > > pointer 'qemu_aio_context' should be checked first before it is used.
> > > qemu_bh_new() will use it.
> > > 
> > > Also add extra newlines to make code well separated and easier to read.
> > 
> > This "also" is not good, please only do one thing in a patch.
> > 
> > Fam
> > 
> 
> Thanks Fam.
> 
> See what I was told before when come to here:
> http://lists.nongnu.org/archive/html/qemu-trivial/2015-10/msg00116.html
> http://lists.nongnu.org/archive/html/qemu-trivial/2015-10/msg00123.html
> 
> So since then, I always prefer to squeeze stylistics patch into a productive
> one.

Yes, but in this patch I think the blank line changes are 1) more of personal
taste, 2) completely unrelated (neither lines nor semantics) to the functional
change.

Fam