[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] qemu-img: fix failed autotests
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] qemu-img: fix failed autotests |
Date: |
Tue, 5 Jul 2016 16:52:34 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 04.07.2016 um 15:16 hat Denis V. Lunev geschrieben:
> There are 9 iotests failed on Ubuntu 15.10 at the moment.
> The problem is that options parsing in qemu-img is broken by the
> following commit:
> commit 10985131e337a0c52c5bd1e191fd7867a6ff8d02
> Author: Denis V. Lunev <address@hidden>
> Date: Fri Jun 17 17:44:13 2016 +0300
> qemu-img: move common options parsing before commands processing
>
> This strange command line reports error
> ./qemu-img create -f qcow2 TEST_DIR/t.qcow2 -- 1024
> qemu-img: Invalid image size specified!
> while original code parses it successfully.
>
> The problem is that getopt_long state should be reset. This could be done
> using this assignment according to the manual:
> optind = 0
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Eric Blake <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
Thanks, applied to the block branch.
Stefan, don't you run qemu-iotests any more before sending pull
requests?
Kevin