[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/24] vhost-user: check vhost_user_write() retu
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH 06/24] vhost-user: check vhost_user_write() return value |
|
Date: |
Tue, 5 Jul 2016 01:36:32 +0300 |
On Tue, Jul 05, 2016 at 12:01:49AM +0200, Marc-André Lureau wrote:
> On Mon, Jul 4, 2016 at 5:46 PM, Michael S. Tsirkin <address@hidden> wrote:
> > Let's just work on handling it. If we need debug messages to help us
> > reach that goal fine. But I don't see many reasons to propagate
> > return codes back and forth if caller just prints and ignores it.
> > Print it where it's detected :)
>
>
> Adding more debug messages is not the point of this patch though, it
> is to break the code flow when an error occurs, not later. Sure we can
> add error_report() in vhost_user_write() that would be more consistent
> with vhost_user_read() actually.
Yes but we should look for more ways to continue after an error,
not for ways to break the flow IMHO.
>
> --
> Marc-André Lureau