[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/7] checkpatch: There is no qemu_strtod()
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 3/7] checkpatch: There is no qemu_strtod() |
Date: |
Thu, 30 Jun 2016 09:29:48 +0200 |
From: Eric Blake <address@hidden>
Maybe there should be; but until there is, we should not flag
strtod() calls as something to replaced with qemu_strtod().
We also lack qemu_strtof() and qemu_strtold(), but as no one
has been using strtof() or strtold(), it's not worth complicating
the regex for them.
(Ironically, I had to use 'git commit -n' since checkpatch uses
TAB indents, in violation of its own recommendations.)
Signed-off-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c939a32..cf32c8f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2453,7 +2453,7 @@ sub process {
}
# recommend qemu_strto* over strto* for numeric conversions
- if ($line =~ /\b(strto[^k].*?)\s*\(/) {
+ if ($line =~ /\b(strto[^kd].*?)\s*\(/) {
WARN("consider using qemu_$1 in preference to $1\n" .
$herecurr);
}
# check for module_init(), use category-specific init macros explicitly please
--
2.5.5
- [Qemu-devel] [PULL 0/7] QAPI patches 2016-06-30, Markus Armbruster, 2016/06/30
- [Qemu-devel] [PULL 1/7] json-streamer: Don't leak tokens on incomplete parse, Markus Armbruster, 2016/06/30
- [Qemu-devel] [PULL 4/7] qapi: Fix crash on missing alternate member of QAPI struct, Markus Armbruster, 2016/06/30
- [Qemu-devel] [PULL 3/7] checkpatch: There is no qemu_strtod(),
Markus Armbruster <=
- [Qemu-devel] [PULL 6/7] qapi: Simplify use of range.h, Markus Armbruster, 2016/06/30
- [Qemu-devel] [PULL 2/7] qobject: Correct JSON lexer grammar comments, Markus Armbruster, 2016/06/30
- [Qemu-devel] [PULL 5/7] range: Create range.c for code that should not be inline, Markus Armbruster, 2016/06/30
- [Qemu-devel] [PULL 7/7] qapi: Fix memleak in string visitors on int lists, Markus Armbruster, 2016/06/30
- Re: [Qemu-devel] [PULL 0/7] QAPI patches 2016-06-30, Peter Maydell, 2016/06/30