Re: [Qemu-devel] [PATCH 0/8] ppc: compute cpu_dt_id in the machine code

[David Gibson]

On Wed, Jun 29, 2016 at 10:50:06PM +0200, Greg Kurz wrote:
> This series is a sequel to the discussion on a patch from Ben's powernv
> patchset:
> 
>         http://patchwork.ozlabs.org/patch/597153/
> 
> Indeed, since the DT is a machine abstraction, it should definitely sit
> under hw/ppc and not in the target code:
> - all machine types are forced to share the same numbering logic
> - user mode does not need that => there are #ifdef everywhere
> 
> So this series moves all the current numbering logic to the machine
> code. It also provides the ability for each machine type to provide
> its own numbering logic instead of using the legacy one.
> 
> The current code computes cpu_dt_id out of cpu_index, both getting
> their values during cpu realization.
> 
> The idea is to compute cpu_index at cpu initialization time, so
> that the machine can compute cpu_dt_id before realizing the cpu.
> 
> I had to fix some issues and to do some more structural changes to have
> this working, hence the RFC tag. The first 4 patches are bug fixes. The
> next ones do what the subject says.
> 
> This patchset is based on David's ppc-for-2.7 branch. I could test it plays
> nicely with Bharata's CPU hotplug code for sPAPR.
> 
> There are some more places where the cpu_dt_id logic is open coded in the
> sPAPR code. It may be worth to consolidate that in follow-up patches. Also
> maybe other machine types may provide their own numbering logic if the
> current one is not appropriate.

Since they're clear bugfixes, I've applied 1-3/8 to ppc-for-2.7.  As
you say the rest of the series needs more discussion.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature