[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 7/8] ppc/xics: Use a helper to add a new ICS
From: |
Nikunj A Dadhania |
Subject: |
[Qemu-devel] [PATCH v2 7/8] ppc/xics: Use a helper to add a new ICS |
Date: |
Wed, 29 Jun 2016 00:35:18 +0530 |
From: Benjamin Herrenschmidt <address@hidden>
Signed-off-by: Benjamin Herrenschmidt <address@hidden>
[Move object allocation and adding child to the helper]
Signed-off-by: Nikunj A Dadhania <address@hidden>
Reviewed-by: David Gibson <address@hidden>
---
hw/intc/xics.c | 10 ++++++++++
hw/intc/xics_spapr.c | 6 +-----
include/hw/ppc/xics.h | 1 +
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/hw/intc/xics.c b/hw/intc/xics.c
index 5148bdf..bbdba84 100644
--- a/hw/intc/xics.c
+++ b/hw/intc/xics.c
@@ -108,6 +108,16 @@ static void xics_common_reset(DeviceState *d)
}
}
+void xics_add_ics(XICSState *xics)
+{
+ ICSState *ics;
+
+ ics = ICS(object_new(TYPE_ICS));
+ object_property_add_child(OBJECT(xics), "ics", OBJECT(ics), NULL);
+ ics->xics = xics;
+ QLIST_INSERT_HEAD(&xics->ics, ics, list);
+}
+
static void xics_prop_get_nr_irqs(Object *obj, Visitor *v, const char *name,
void *opaque, Error **errp)
{
diff --git a/hw/intc/xics_spapr.c b/hw/intc/xics_spapr.c
index 0b0845d..270f20e 100644
--- a/hw/intc/xics_spapr.c
+++ b/hw/intc/xics_spapr.c
@@ -305,12 +305,8 @@ static void xics_spapr_realize(DeviceState *dev, Error
**errp)
static void xics_spapr_initfn(Object *obj)
{
XICSState *xics = XICS_SPAPR(obj);
- ICSState *ics;
- ics = ICS(object_new(TYPE_ICS));
- object_property_add_child(obj, "ics", OBJECT(ics), NULL);
- ics->xics = xics;
- QLIST_INSERT_HEAD(&xics->ics, ics, list);
+ xics_add_ics(xics);
}
static void xics_spapr_class_init(ObjectClass *oc, void *data)
diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h
index 8c22daf..8433bf9 100644
--- a/include/hw/ppc/xics.h
+++ b/include/hw/ppc/xics.h
@@ -196,5 +196,6 @@ void ics_write_xive(ICSState *ics, int nr, int server,
void ics_set_irq_type(ICSState *ics, int srcno, bool lsi);
ICSState *xics_find_source(XICSState *icp, int irq);
+void xics_add_ics(XICSState *xics);
#endif /* __XICS_H__ */
--
2.7.4
- [Qemu-devel] [PATCH v2 0/8] sPAPR xics rework/cleanup, Nikunj A Dadhania, 2016/06/28
- [Qemu-devel] [PATCH v2 1/8] ppc/xics: Rename existing xics to xics_spapr, Nikunj A Dadhania, 2016/06/28
- [Qemu-devel] [PATCH v2 2/8] ppc/xics: Move SPAPR specific code to a separate file, Nikunj A Dadhania, 2016/06/28
- [Qemu-devel] [PATCH v2 3/8] ppc/xics: Implement H_IPOLL using an accessor, Nikunj A Dadhania, 2016/06/28
- [Qemu-devel] [PATCH v2 4/8] ppc/xics: Replace "icp" with "xics" in most places, Nikunj A Dadhania, 2016/06/28
- [Qemu-devel] [PATCH v2 6/8] ppc/xics: An ICS with offset 0 is assumed to be uninitialized, Nikunj A Dadhania, 2016/06/28
- [Qemu-devel] [PATCH v2 5/8] ppc/xics: Make the ICSState a list, Nikunj A Dadhania, 2016/06/28
- [Qemu-devel] [PATCH v2 7/8] ppc/xics: Use a helper to add a new ICS,
Nikunj A Dadhania <=
- [Qemu-devel] [PATCH v2 8/8] ppc/xics: Split ICS into ics-base and ics class, Nikunj A Dadhania, 2016/06/28
- Re: [Qemu-devel] [PATCH v2 0/8] sPAPR xics rework/cleanup, David Gibson, 2016/06/28