[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor |
|
Date: |
Tue, 28 Jun 2016 08:10:50 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/28/2016 04:17 AM, Dr. David Alan Gilbert wrote:
>> QmpInputVisitor is used to parse all QMP monitor commands, so will
>> be used continuously throughout life of QEMU, often very frequently.
>> eg When migration is running many monitor commands per second are
>> expected
>
> Does the same input visitor get reused by each command?
No; in fact commit f2ff429 changed things to intentionally prevent reuse
of a visitor (on the argument that it was easier to do that than to
think about corner cases of reset after a partial visit encountered
errors). But we can revisit that decision if reusing a static
QmpInputVisitor would be wiser than allocating a fresh one for every visit.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 12/15] util: add a function to realloc mmapped memory, (continued)
Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor, Paolo Bonzini, 2016/06/28
Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor, Markus Armbruster, 2016/06/30
[Qemu-devel] [PATCH 10/15] vmware_svga: use mmap for scratch pad, Peter Lieven, 2016/06/28
[Qemu-devel] [PATCH 04/15] coroutine: add a knob to disable the shared release pool, Peter Lieven, 2016/06/28
[Qemu-devel] [PATCH 05/15] util: add a helper to mmap private anonymous memory, Peter Lieven, 2016/06/28
[Qemu-devel] [PATCH 06/15] exec: use mmap for subpages, Peter Lieven, 2016/06/28